Code Review for illumos-gate

Prepared by:david (david) on 2013-Jun-16 17:44 +0000 UTC
Workspace:/home/david/ws/illumos-gate (at df7bd1a5cb86)
Compare against: be468fc6d7266e97f1330a (at be468fc6d726)
Summary of changes: 987 lines changed: 949 ins; 1 del; 37 mod; 8260 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/iso/locale_iso.h

2964 need POSIX 2008 locale object support
9 lines changed: 9 ins; 0 del; 0 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/amd64/Makefile

2964 need POSIX 2008 locale object support
2 lines changed: 1 ins; 0 del; 1 mod; 1222 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/Makefile.com

2964 need POSIX 2008 locale object support
2 lines changed: 1 ins; 0 del; 1 mod; 1294 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/collate.c

2964 need POSIX 2008 locale object support
32 lines changed: 32 ins; 0 del; 0 mod; 637 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/collate.h

2964 need POSIX 2008 locale object support
10 lines changed: 10 ins; 0 del; 0 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmessages.c

2964 need POSIX 2008 locale object support
58 lines changed: 43 ins; 0 del; 15 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmessages.h

2964 need POSIX 2008 locale object support
14 lines changed: 13 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmonetary.c

2964 need POSIX 2008 locale object support
51 lines changed: 46 ins; 0 del; 5 mod; 133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmonetary.h

2964 need POSIX 2008 locale object support
14 lines changed: 13 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lnumeric.c

2964 need POSIX 2008 locale object support
14 lines changed: 14 ins; 0 del; 0 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lnumeric.h

2964 need POSIX 2008 locale object support
13 lines changed: 13 ins; 0 del; 0 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/localeconv.c

2964 need POSIX 2008 locale object support
21 lines changed: 12 ins; 0 del; 9 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/mblocal.h

2964 need POSIX 2008 locale object support
20 lines changed: 20 ins; 0 del; 0 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/nl_langinfo.c

2964 need POSIX 2008 locale object support
14 lines changed: 11 ins; 0 del; 3 mod; 193 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/none.c

2964 need POSIX 2008 locale object support
29 lines changed: 29 ins; 0 del; 0 mod; 199 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/setlocale.c

2964 need POSIX 2008 locale object support
13 lines changed: 11 ins; 1 del; 1 mod; 327 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/setlocale.h

2964 need POSIX 2008 locale object support
1 line changed: 1 ins; 0 del; 0 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/setrunelocale.c

2964 need POSIX 2008 locale object support
32 lines changed: 32 ins; 0 del; 0 mod; 252 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/timelocal.c

2964 need POSIX 2008 locale object support
13 lines changed: 13 ins; 0 del; 0 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/timelocal.h

2964 need POSIX 2008 locale object support
12 lines changed: 12 ins; 0 del; 0 mod; 52 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/locale/xlocale.c

2964 need POSIX 2008 locale object support
363 lines changed: 363 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/locale/xlocale_private.h

2964 need POSIX 2008 locale object support
241 lines changed: 241 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/mapfile-vers

2964 need POSIX 2008 locale object support
9 lines changed: 9 ins; 0 del; 0 mod; 3134 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.