| Prepared by: | admin (admin) on 2013-May-16 17:36 -0600 MDT |
|---|---|
| Workspace: | /home/admin/ws/illumos-gate (at 2d2613ab66c7) |
| Compare against: | 506c92de738458eb87bdd683539361046b589292 (at 506c92de7384) |
| Summary of changes: | 357 lines changed: 92 ins; 115 del; 150 mod; 56533 unchg |
| Patch of changes: | illumos-3742.2.patch |
| Printable review: | illumos-3742.2.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/arc.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>8 lines changed: 0 ins; 2 del; 6 mod; 4790 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/bptree.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 0 ins; 0 del; 1 mod; 224 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dnode.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>10 lines changed: 2 ins; 0 del; 8 mod; 1992 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dnode_sync.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>2 lines changed: 0 ins; 0 del; 2 mod; 694 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dsl_prop.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 0 ins; 0 del; 1 mod; 1128 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sa.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>3 lines changed: 1 ins; 2 del; 0 mod; 1992 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>7 lines changed: 1 ins; 2 del; 4 mod; 6465 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa_config.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 1 ins; 0 del; 0 mod; 508 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa_misc.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 0 ins; 0 del; 1 mod; 1847 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/ddt.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>14 lines changed: 6 ins; 7 del; 1 mod; 238 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/dnode.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>3 lines changed: 0 ins; 1 del; 2 mod; 326 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/dsl_pool.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 1 ins; 0 del; 0 mod; 162 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/sa_impl.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>36 lines changed: 17 ins; 18 del; 1 mod; 269 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/spa_impl.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 0 ins; 0 del; 1 mod; 259 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/space_map.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 0 ins; 1 del; 0 mod; 187 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/unique.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 0 ins; 0 del; 1 mod; 58 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/vdev_impl.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>7 lines changed: 3 ins; 1 del; 3 mod; 332 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/zap.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>28 lines changed: 15 ins; 8 del; 5 mod; 468 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/zap_leaf.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>10 lines changed: 1 ins; 4 del; 5 mod; 236 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/zfs_acl.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>4 lines changed: 2 ins; 1 del; 1 mod; 243 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/zfs_rlock.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>9 lines changed: 1 ins; 2 del; 6 mod; 81 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/zfs_znode.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>14 lines changed: 5 ins; 7 del; 2 mod; 353 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/zil.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>13 lines changed: 6 ins; 7 del; 0 mod; 423 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/zio_compress.h
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>4 lines changed: 1 ins; 2 del; 1 mod; 88 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/txg.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>3 lines changed: 0 ins; 0 del; 3 mod; 816 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/vdev.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>11 lines changed: 4 ins; 0 del; 7 mod; 3188 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/vdev_queue.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>9 lines changed: 4 ins; 3 del; 2 mod; 463 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/vdev_raidz.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>7 lines changed: 2 ins; 3 del; 2 mod; 2211 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_acl.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>6 lines changed: 2 ins; 1 del; 3 mod; 2692 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_ctldir.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 1 ins; 0 del; 0 mod; 1359 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_ioctl.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>11 lines changed: 3 ins; 7 del; 1 mod; 5910 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_log.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>11 lines changed: 0 ins; 1 del; 10 mod; 664 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_rlock.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 0 ins; 0 del; 1 mod; 604 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_sa.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>1 line changed: 0 ins; 0 del; 1 mod; 333 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_vfsops.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>14 lines changed: 0 ins; 4 del; 10 mod; 2337 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_vnops.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>78 lines changed: 9 ins; 26 del; 43 mod; 5197 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_znode.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>11 lines changed: 0 ins; 5 del; 6 mod; 2137 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zil.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>3 lines changed: 1 ins; 0 del; 2 mod; 2113 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zio.c
3742 zfs comments need cleaner, more consistent style Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com>10 lines changed: 3 ins; 0 del; 7 mod; 3146 unchg
This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.