| Prepared by: | admin (admin) on 2013-Apr-23 14:09 -0600 MDT |
|---|---|
| Workspace: | /home/admin/ws/illumos-gate (at 0addfdfe7cb0) |
| Compare against: | 6f9d4f1be0becb974c8f6cc74b0f1a87f766c4fe (at 6f9d4f1be0be) |
| Summary of changes: | 169 lines changed: 157 ins; 0 del; 12 mod; 29020 unchg |
| Patch of changes: | illumos-3741.patch |
| Printable review: | illumos-3741.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/zfs/zfs_fletcher.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>11 lines changed: 11 ins; 0 del; 0 mod; 246 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_dataset.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>5 lines changed: 5 ins; 0 del; 0 mod; 4467 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/arc.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>17 lines changed: 15 ins; 0 del; 2 mod; 4781 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dbuf.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>23 lines changed: 22 ins; 0 del; 1 mod; 2712 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dmu.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>1 line changed: 0 ins; 0 del; 1 mod; 1835 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dmu_tx.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>8 lines changed: 8 ins; 0 del; 0 mod; 1392 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dmu_zfetch.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>8 lines changed: 1 ins; 0 del; 7 mod; 717 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>2 lines changed: 2 ins; 0 del; 0 mod; 6469 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/dmu.h
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>8 lines changed: 8 ins; 0 del; 0 mod; 804 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/txg.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>15 lines changed: 14 ins; 0 del; 1 mod; 806 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/vdev_label.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>1 line changed: 1 ins; 0 del; 0 mod; 1286 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/vdev_raidz.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>65 lines changed: 65 ins; 0 del; 0 mod; 2151 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_ctldir.c
3741 zfs needs better comments Submitted by: Will Andrews <willa@spectralogic.com> Submitted by: Justin Gibbs <justing@spectralogic.com> Submitted by: Alan Somers <alans@spectralogic.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com>5 lines changed: 5 ins; 0 del; 0 mod; 1354 unchg
This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.