Code Review for wr-5ae183d

Prepared by:Richard Lowe (richlowe) on 2014-Jan-14 16:49 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at 5ae183dc4a4f)
Compare against: HEAD^ (at 32fb9711724d)
Summary of changes: 1428 lines changed: 1423 ins; 1 del; 4 mod; 22624 unchg
Patch of changes: wr-5ae183d.patch
Printable review: wr-5ae183d.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dtrace/test/tst/common/Makefile

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
13 lines changed: 13 ins; 0 del; 0 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.subr.d

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
3 lines changed: 3 ins; 0 del; 0 mod; 113 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/json/tst.general.d

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
179 lines changed: 179 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/json/tst.general.d.out

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
218 lines changed: 218 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/json/tst.strsize.d

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/json/tst.strsize.d.out

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
13 lines changed: 13 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/json/tst.usdt.c

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/json/tst.usdt.d

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/json/tst.usdt.d.out

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
11 lines changed: 11 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/json/usdt.d

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dtrace/test/tst/common/privs/tst.func_access.ksh

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
8 lines changed: 6 ins; 1 del; 1 mod; 80 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/strtoll/err.BaseTooLarge.d

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/strtoll/err.BaseTooSmall.d

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/strtoll/tst.strtoll.d

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/strtoll/tst.strtoll.d.out

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
20 lines changed: 20 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/util/strtolctype.h

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 75 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_open.c

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
8 lines changed: 6 ins; 0 del; 2 mod; 1413 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-dtrace-tests.mf

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
13 lines changed: 13 ins; 0 del; 0 mod; 2060 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/dtrace/dtrace.c

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
593 lines changed: 593 ins; 0 del; 0 mod; 16252 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/dtrace.h

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
3 lines changed: 2 ins; 0 del; 1 mod; 2337 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/dtrace/Makefile

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
2 lines changed: 2 ins; 0 del; 0 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/dtrace/Makefile

4477 DTrace should speak JSON
Reviewed by: Bryan Cantrill <bmc@joyent.com>
1 line changed: 1 ins; 0 del; 0 mod; 97 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.