Print this page
code review from Josh and Robert

Split Close
Expand all
Collapse all
          --- old/usr/src/man/man9f/vmem_walk.9f
          +++ new/usr/src/man/man9f/vmem_walk.9f
↓ open down ↓ 29 lines elided ↑ open up ↑
  30   30  .Ft size_t
  31   31  .Fo vmem_size
  32   32  .Fa "vmem_t *vmp"
  33   33  .Fa "int typemask"
  34   34  .Fc
  35   35  .Sh INTERFACE LEVEL
  36   36  illumos DDI specific
  37   37  .Sh PARAMETERS
  38   38  .Bl -tag -width Ds
  39   39  .It Fa vmp
  40      -The vmem arena to walk
       40 +The vmem arena to walk.
  41   41  .It Fa typemask
  42      -A bitmask indicating the types of segment to operate on
       42 +A bitmask indicating the types of segment to operate on.
  43   43  .Bl -tag -width Ds
  44   44  .It Dv VMEM_ALLOC
  45      -Allocated segments
       45 +Allocated segments.
  46   46  .It Dv VMEM_FREE
  47      -Free segments
       47 +Free segments.
  48   48  .El
  49   49  .It Fa func
  50   50  The function to apply to each segment matching
  51   51  .Fa typemask .
  52   52  .Fa func
  53      -should be of 3 values and return void:
       53 +should accept 3 arguments and return void:
  54   54  .Bl -tag -width Ds
  55   55  .It Fa "void *arg"
  56   56  The
  57   57  .Fa arg
  58   58  passed to
  59      -.Fn vmem_walk
       59 +.Fn vmem_walk .
  60   60  .It Fa "void *vaddr"
  61      -The base address of the segment
       61 +The base address of the segment.
  62   62  .It Fa "size_t size"
  63      -The size of the segment
       63 +The size of the segment.
  64   64  .El
  65   65  .It Fa arg
  66   66  An arbitrary argument passed to each call to
  67      -.Fn func
       67 +.Fn func .
  68   68  .El
  69   69  .Sh DESCRIPTION
  70   70  .Fn vmem_walk
  71   71  walks each segment in the arena
  72   72  .Fa vmp
  73   73  and applies
  74   74  .Fa func
  75   75  to each which matches
  76   76  .Fa typemask .
  77   77  .Pp
↓ open down ↓ 11 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX