Code Review for il_multicw

Prepared by:Richard Lowe (richlowe) on 2018-Feb-17 00:12 +0000 UTC
Workspace:/builds/work/illumos/illumos-git (at 618880584a90)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 66492cf01c4f)
Summary of changes: 860 lines changed: 220 ins; 378 del; 262 mod; 6153 unchg
Patch of changes: il_multicw.patch
Printable review: il_multicw.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
34 lines changed: 0 ins; 28 del; 6 mod; 254 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
36 lines changed: 9 ins; 14 del; 13 mod; 1157 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master.64
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
3 lines changed: 0 ins; 3 del; 0 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dtrace/test/tst/common/Makefile

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
6 lines changed: 0 ins; 6 del; 0 mod; 165 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/dtrace/test/tst/common/pid/tst.gcc.c (deleted)

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
63 lines changed: 0 ins; 63 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/dtrace/test/tst/common/pid/tst.gcc.d (deleted)

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
52 lines changed: 0 ins; 52 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/mapfiles/gen/Makefile

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
11 lines changed: 0 ins; 4 del; 7 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/Makefile.targ

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
1 line changed: 0 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-dtrace-tests.mf

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
2 lines changed: 0 ins; 2 del; 0 mod; 2141 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/tests/file-locking/Makefile

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
12 lines changed: 6 ins; 0 del; 6 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/Makefile

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
6 lines changed: 0 ins; 4 del; 2 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/cw.1onbld
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
250 lines changed: 55 ins; 63 del; 132 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/cw.c

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
349 lines changed: 125 ins; 133 del; 91 mod; 1694 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/env/illumos.sh

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
24 lines changed: 22 ins; 0 del; 2 mod; 224 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ndrgen/ndrgen.sh

cw: give cw(1onbld) a new interface allowing for multiple arbitrary shadows
11 lines changed: 3 ins; 6 del; 2 mod; 128 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.