Code Review for il_7069

Prepared by:Richard Lowe (richlowe) on 2016-Jun-18 19:38 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at 469e69755cd3)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 0f5217fdd659)
Summary of changes: 89 lines changed: 15 ins; 1 del; 73 mod; 4689 unchg
Patch of changes: il_7069.patch
Printable review: il_7069.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

7069 i386_XARCH should include -m32
1 line changed: 0 ins; 0 del; 1 mod; 1172 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/dns-sd/Makefile

7120 mDNS resync was not wsdiff safe
1 line changed: 1 ins; 0 del; 0 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/dns-sd/dns-sd.c

7120 mDNS resync was not wsdiff safe
73 lines changed: 4 ins; 0 del; 69 mod; 1751 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdns_sd/Makefile.com

7120 mDNS resync was not wsdiff safe
1 line changed: 1 ins; 0 del; 0 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdns_sd/common/dnssd_clientlib.c

7120 mDNS resync was not wsdiff safe
4 lines changed: 4 ins; 0 del; 0 mod; 366 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdns_sd/java/Makefile.com

7120 mDNS resync was not wsdiff safe
2 lines changed: 1 ins; 1 del; 0 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdns_sd/java/common/JNISupport.c

7120 mDNS resync was not wsdiff safe
4 lines changed: 4 ins; 0 del; 0 mod; 1072 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfru/amd64/Makefile

7069 i386_XARCH should include -m32
1 line changed: 0 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfru/sparcv9/Makefile

7069 i386_XARCH should include -m32
1 line changed: 0 ins; 0 del; 1 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/libc-tests/tests/Makefile

7069 i386_XARCH should include -m32
1 line changed: 0 ins; 0 del; 1 mod; 97 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.