Print this page
Code review comments from pmooney (sundry), and igork (screwups in zonecfg refactoring)

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/sun4u/vm/mach_vm_dep.c
          +++ new/usr/src/uts/sun4u/vm/mach_vm_dep.c
↓ open down ↓ 307 lines elided ↑ open up ↑
 308  308                          (void) random_get_pseudo_bytes((uint8_t *)&slew,
 309  309                              sizeof (slew));
 310  310  
 311  311                          maxslew = MIN(aslr_max_map_skew, (addr - base));
 312  312                          /*
 313  313                           * Don't allow ASLR to cause mappings to fail below
 314  314                           * because of SF erratum #57
 315  315                           */
 316  316                          maxslew = MIN(maxslew, (addr - errata57_limit));
 317  317  
 318      -                        slew = slew % MIN(MIN(aslr_max_map_skew, (addr - base)),
 319      -                            addr - errata57_limit);
      318 +                        slew = slew % maxslew;
 320  319                          addr -= P2ALIGN(slew, align_amount);
 321  320                  }
 322  321  
 323  322                  ASSERT(addr > base);
 324  323                  ASSERT(addr + len < base + slen);
 325  324                  ASSERT(((uintptr_t)addr & (align_amount - 1l)) ==
 326  325                      ((uintptr_t)(off)));
 327  326                  *addrp = addr;
 328  327  
 329  328  #if defined(SF_ERRATA_57)
↓ open down ↓ 54 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX