Print this page
Code review comments from jeffpc

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/sgs/elfdump/common/corenote.c
          +++ new/usr/src/cmd/sgs/elfdump/common/corenote.c
↓ open down ↓ 829 lines elided ↑ open up ↑
 830  830  }
 831  831  
 832  832  /*
 833  833   * Output information from prsecflags_t structure.
 834  834   */
 835  835  static void
 836  836  dump_secflags(note_state_t *state, const char *title)
 837  837  {
 838  838          const sl_prsecflags_layout_t *layout = state->ns_arch->prsecflags;
 839  839          Conv_secflags_buf_t inv;
      840 +        Lword lw;
 840  841          Word w;
 841  842  
 842  843          indent_enter(state, title, &layout->pr_version);
 843  844  
 844  845          w = extract_as_word(state, &layout->pr_version);
 845  846  
 846  847          if (w != PRSECFLAGS_VERSION_1) {
 847  848                  PRINT_DEC(MSG_INTL(MSG_NOTE_BAD_SECFLAGS_VER), pr_version);
 848  849                  dump_hex_bytes(state->ns_data, state->ns_len, state->ns_indent,
 849  850                      4, 3);
 850  851          } else {
 851  852                  PRINT_DEC(MSG_ORIG(MSG_CNOTE_T_PR_VERSION), pr_version);
 852      -                w = extract_as_word(state, &layout->pr_effective);
      853 +                lw = extract_as_lword(state, &layout->pr_effective);
 853  854                  print_str(state, MSG_ORIG(MSG_CNOTE_T_PR_EFFECTIVE),
 854      -                    conv_prsecflags(w, 0, &inv));
      855 +                    conv_prsecflags(lw, 0, &inv));
 855  856  
 856      -                w = extract_as_word(state, &layout->pr_inherit);
      857 +                lw = extract_as_lword(state, &layout->pr_inherit);
 857  858                  print_str(state, MSG_ORIG(MSG_CNOTE_T_PR_INHERIT),
 858      -                    conv_prsecflags(w, 0, &inv));
      859 +                    conv_prsecflags(lw, 0, &inv));
 859  860  
 860      -                w = extract_as_word(state, &layout->pr_lower);
      861 +                lw = extract_as_lword(state, &layout->pr_lower);
 861  862                  print_str(state, MSG_ORIG(MSG_CNOTE_T_PR_LOWER),
 862      -                    conv_prsecflags(w, 0, &inv));
      863 +                    conv_prsecflags(lw, 0, &inv));
 863  864  
 864      -                w = extract_as_word(state, &layout->pr_upper);
      865 +                lw = extract_as_lword(state, &layout->pr_upper);
 865  866                  print_str(state, MSG_ORIG(MSG_CNOTE_T_PR_UPPER),
 866      -                    conv_prsecflags(w, 0, &inv));
      867 +                    conv_prsecflags(lw, 0, &inv));
 867  868          }
 868  869  
 869  870          indent_exit(state);
 870  871  }
 871  872  
 872  873  /*
 873  874   * Output information from utsname structure.
 874  875   */
 875  876  static void
 876  877  dump_utsname(note_state_t *state, const char *title)
↓ open down ↓ 1036 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX