Code Review for il_3772-hack

Prepared by:Richard Lowe (richlowe) on 2013-Oct-11 14:56 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at ebcc93ef7d09)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 018d3f06fe63)
Summary of changes: 497 lines changed: 73 ins; 413 del; 11 mod; 3873 unchg
Patch of changes: il_3772-hack.patch
Printable review: il_3772-hack.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/Makefile.com

libc: only have one select implementation, and move the pollfds onto the heap if they cross some threshold
1 line changed: 0 ins; 1 del; 0 mod; 1294 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/gen/select.c

select: shortcircuit fd_sets_count if given 0 fds (such as for timing)
if nfds is low, fastpath to try to maintain throughput
libc: only have one select implementation, and move the pollfds onto the heap if they cross some threshold
84 lines changed: 73 ins; 3 del; 8 mod; 302 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libc/port/gen/select_large_fdset.c (deleted)

libc: only have one select implementation, and move the pollfds onto the heap if they cross some threshold
392 lines changed: 0 ins; 392 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparc/Makefile.com

libc: only have one select implementation, and move the pollfds onto the heap if they cross some threshold
1 line changed: 0 ins; 1 del; 0 mod; 1374 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/conf/param.c

3772 consider raising default descriptor soft limit
Reviewed by: Piotr Jasiukajtis <estibi@me.com>
Reviewed by: Saso Kiselkov <skiselkov.ml@gmail.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
2 lines changed: 0 ins; 0 del; 2 mod; 743 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/select.h

libc: only have one select implementation, and move the pollfds onto the heap if they cross some threshold
17 lines changed: 0 ins; 16 del; 1 mod; 160 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.