Code Review for il_3544-schrock

Prepared by:Richard Lowe (richlowe) on 2013-Feb-22 23:58 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at fadd5be4590c)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 77372cb0f35e)
Summary of changes: 535 lines changed: 449 ins; 34 del; 52 mod; 1653 unchg
Patch of changes: il_3544-schrock.patch
Printable review: il_3544-schrock.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/saveargs/saveargs.c

saveargs: let disasm do the lifting
3544 save-args matcher could be considerably more robust
3545 save-args matcher should accept saves maybe out-of-order
Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
170 lines changed: 123 ins; 18 del; 29 mod; 221 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/saveargs/tests/README

3544 save-args matcher could be considerably more robust
3545 save-args matcher should accept saves maybe out-of-order
Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
5 lines changed: 5 ins; 0 del; 0 mod; 9 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/saveargs/tests/dump/Makefile

saveargs: let disasm do the lifting
3544 save-args matcher could be considerably more robust
3545 save-args matcher should accept saves maybe out-of-order
Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/saveargs/tests/dump/dump.c

3544 save-args matcher could be considerably more robust
3545 save-args matcher should accept saves maybe out-of-order
Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/saveargs/tests/testmatch/Makefile

saveargs: let disasm do the lifting
3544 save-args matcher could be considerably more robust
3545 save-args matcher should accept saves maybe out-of-order
Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
6 lines changed: 5 ins; 0 del; 1 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/saveargs/tests/testmatch/data.s

3544 save-args matcher could be considerably more robust
3545 save-args matcher should accept saves maybe out-of-order
Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
58 lines changed: 58 ins; 0 del; 0 mod; 396 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/saveargs/tests/testmatch/testmatch.c

3544 save-args matcher could be considerably more robust
3545 save-args matcher should accept saves maybe out-of-order
Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
57 lines changed: 36 ins; 0 del; 21 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm.h

saveargs: let disasm do the lifting
3 lines changed: 1 ins; 2 del; 0 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/mapfile-vers

saveargs: let disasm do the lifting
1 line changed: 1 ins; 0 del; 0 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/i386/dis_i386.c

saveargs: let disasm do the lifting
11 lines changed: 9 ins; 2 del; 0 mod; 245 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/sparc/dis_sparc.c

saveargs: let disasm do the lifting
9 lines changed: 6 ins; 3 del; 0 mod; 336 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libproc/Makefile.com

saveargs: let disasm do the lifting
3544 save-args matcher could be considerably more robust
3545 save-args matcher should accept saves maybe out-of-order
Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
7 lines changed: 0 ins; 7 del; 0 mod; 122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libproc/amd64/Makefile

saveargs: let disasm do the lifting
9 lines changed: 6 ins; 2 del; 1 mod; 33 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.