Code Review for il_3337

Prepared by:Richard Lowe (richlowe) on 2012-Nov-05 20:40 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at 8e5b8ecdc36c)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 7c45eec5760d)
Summary of changes: 691 lines changed: 676 ins; 1 del; 14 mod; 1622 unchg
Patch of changes: il_3337.patch
Printable review: il_3337.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/machrel.amd.c

3337 x64 link-editor is painfully literal-minded about TLS
90 lines changed: 75 ins; 1 del; 14 mod; 1622 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/Makefile

3337 x64 link-editor is painfully literal-minded about TLS
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/README

3337 x64 link-editor is painfully literal-minded about TLS
9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/orig/style1-func.c

3337 x64 link-editor is painfully literal-minded about TLS
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/orig/style1-main.c

3337 x64 link-editor is painfully literal-minded about TLS
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/orig/style2.c

3337 x64 link-editor is painfully literal-minded about TLS
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/style1-func-with-r12.s

3337 x64 link-editor is painfully literal-minded about TLS
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/style1-func-with-r13.s

3337 x64 link-editor is painfully literal-minded about TLS
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/style1-func.s

3337 x64 link-editor is painfully literal-minded about TLS
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/style1-main.s

3337 x64 link-editor is painfully literal-minded about TLS
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/style2-with-badness.s

3337 x64 link-editor is painfully literal-minded about TLS
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/style2-with-r12.s

3337 x64 link-editor is painfully literal-minded about TLS
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/style2-with-r13.s

3337 x64 link-editor is painfully literal-minded about TLS
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/style2.s

3337 x64 link-editor is painfully literal-minded about TLS
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sgs/test/ld/x64/tls/ie/x64-ie-test.sh

3337 x64 link-editor is painfully literal-minded about TLS
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.