Print this page
code review from Robert

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/sgs/libld/common/syms.c
          +++ new/usr/src/cmd/sgs/libld/common/syms.c
↓ open down ↓ 953 lines elided ↑ open up ↑
 954  954  /*
 955  955   * At this point all symbol input processing has been completed, therefore
 956  956   * complete the symbol table entries by generating any necessary internal
 957  957   * symbols.
 958  958   */
 959  959  uintptr_t
 960  960  ld_sym_spec(Ofl_desc *ofl)
 961  961  {
 962  962          Sym_desc        *sdp;
 963  963          Sg_desc         *sgp;
 964      -        Aliste          idx1;
 965  964  
 966  965          DBG_CALL(Dbg_syms_spec_title(ofl->ofl_lml));
 967  966  
 968  967          /*
 969  968           * For each section in the output file, look for symbols named for the
 970  969           * __start/__stop patterns.  If references exist, flesh the symbols to
 971  970           * be defined.
 972  971           *
 973  972           * The symbols are given values at the same time as the other special
 974  973           * symbols.
 975  974           */
 976  975          if (!(ofl->ofl_flags & FLG_OF_RELOBJ) ||
 977  976              (ofl->ofl_flags & FLG_OF_KMOD)) {
      977 +                Aliste          idx1;
      978 +
 978  979                  for (APLIST_TRAVERSE(ofl->ofl_segs, idx1, sgp)) {
 979  980                          Os_desc *osp;
 980  981                          Aliste idx2;
 981  982  
 982  983                          for (APLIST_TRAVERSE(sgp->sg_osdescs, idx2, osp)) {
 983  984                                  if (is_cname(osp->os_name)) {
 984  985                                          sym_add_bounds(ofl, osp,
 985  986                                              SDAUX_ID_SECBOUND_START);
 986  987                                          sym_add_bounds(ofl, osp,
 987  988                                              SDAUX_ID_SECBOUND_STOP);
↓ open down ↓ 2242 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX