Print this page
Code review comments

*** 482,504 **** # Sometimes we want all symbols and types in debugging information even # if they aren't used. CALLSYMS= -W0,-xdbggen=no%usedonly # ! # Default debug format for Sun Studio 11 is dwarf, so force it to ! # generate stabs. # DEBUGFORMAT= -_cc=-xdebugformat=stabs -_gcc=-gdwarf-2 # # Ask the compiler to include debugging information # CCGDEBUG= -g $(DEBUGFORMAT) # ! # Flags used to build in debug mode for ctf generation. Bugs in the Devpro ! # compilers currently prevent us from building with cc-emitted DWARF. # CTF_FLAGS_sparc = $(CCGDEBUG) -Wc,-Qiselect-T1 $(CSTD) $(CNOGLOBAL) CTF_FLAGS_i386 = $(CCGDEBUG) $(CSTD) $(CNOGLOBAL) CTF_FLAGS_sparcv9 = $(CTF_FLAGS_sparc) --- 482,504 ---- # Sometimes we want all symbols and types in debugging information even # if they aren't used. CALLSYMS= -W0,-xdbggen=no%usedonly # ! # We force the compilers to generate the debugging information best understood ! # by the CTF tools. With Sun Studio this is stabs due to bugs in the Studio ! # compilers. With GCC this is DWARF v2. # DEBUGFORMAT= -_cc=-xdebugformat=stabs -_gcc=-gdwarf-2 # # Ask the compiler to include debugging information # CCGDEBUG= -g $(DEBUGFORMAT) # ! # Flags used to build in debug mode for ctf generation. # CTF_FLAGS_sparc = $(CCGDEBUG) -Wc,-Qiselect-T1 $(CSTD) $(CNOGLOBAL) CTF_FLAGS_i386 = $(CCGDEBUG) $(CSTD) $(CNOGLOBAL) CTF_FLAGS_sparcv9 = $(CTF_FLAGS_sparc)
*** 512,528 **** CTF_FLAGS = $(CTF_FLAGS_32) # # Flags used with genoffsets # ! GENOFFFLAGS = $(CALLSYMS) OFFSETS_CREATE = $(GENOFFSETS) -s $(CTFSTABS) -r $(CTFCONVERT) \ ! $(CW) --noecho $(CW_CC_COMPILERS) -- $(GENOFFFLAGS) $(CFLAGS) $(CPPFLAGS) OFFSETS_CREATE64 = $(GENOFFSETS) -s $(CTFSTABS) -r $(CTFCONVERT) \ ! $(CW) --noecho $(CW_CC_COMPILERS) -- $(GENOFFFLAGS) $(CFLAGS64) $(CPPFLAGS) # # tradeoff time for space (smaller is better) # sparc_SPACEFLAG = -xspace -W0,-Lt --- 512,530 ---- CTF_FLAGS = $(CTF_FLAGS_32) # # Flags used with genoffsets # ! GENOFFSETS_FLAGS = $(CALLSYMS) OFFSETS_CREATE = $(GENOFFSETS) -s $(CTFSTABS) -r $(CTFCONVERT) \ ! $(CW) --noecho $(CW_CC_COMPILERS) -- $(GENOFFSETS_FLAGS) \ ! $(CFLAGS) $(CPPFLAGS) OFFSETS_CREATE64 = $(GENOFFSETS) -s $(CTFSTABS) -r $(CTFCONVERT) \ ! $(CW) --noecho $(CW_CC_COMPILERS) -- $(GENOFFSETS_FLAGS) \ ! $(CFLAGS64) $(CPPFLAGS) # # tradeoff time for space (smaller is better) # sparc_SPACEFLAG = -xspace -W0,-Lt