Code Review for il-nfs-kstat-per-client

Prepared by:Marcel Telka (marcel) on 2016-Apr-21 21:17 +0200 CEST
Workspace:/data/builds/il-nfs-kstat-per-client (at 8a22d5b65284)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at 380fd671753d)
Summary of changes: 3035 lines changed: 2334 ins; 448 del; 253 mod; 27317 unchg
Patch of changes: il-nfs-kstat-per-client.patch
Printable review: il-nfs-kstat-per-client.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
4 lines changed: 2 ins; 1 del; 1 mod; 2174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_dispatch.c

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
32 lines changed: 24 ins; 1 del; 7 mod; 621 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_srv.c

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
180 lines changed: 95 ins; 25 del; 60 mod; 9958 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_srv_ns.c

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
11 lines changed: 0 ins; 7 del; 4 mod; 1133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_export.c

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
117 lines changed: 7 ins; 99 del; 11 mod; 2742 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_server.c

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
141 lines changed: 77 ins; 17 del; 47 mod; 3483 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/fs/nfs/nfs_srvstats.c

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
1918 lines changed: 1918 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_stats.c

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
330 lines changed: 5 ins; 280 del; 45 mod; 667 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/nfs/export.h

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
10 lines changed: 0 ins; 8 del; 2 mod; 681 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/nfs/nfs.h

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
223 lines changed: 199 ins; 4 del; 20 mod; 2352 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/nfs/nfs4.h

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
57 lines changed: 4 ins; 5 del; 48 mod; 1344 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/nfs/nfs4_kprot.h

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
7 lines changed: 3 ins; 1 del; 3 mod; 1674 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/nfs/nfs_acl.h

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
3 lines changed: 0 ins; 0 del; 3 mod; 401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/nfs/nfs_dispatch.h

6696 Per-client NFS server IOPS, bandwidth, and latency kstats
6472 Panic in rfs4_compound_kstat_res()
6476 Taking exported_lock RW_READER lock in common_dispatch() can cause deadlock in nfssrv
Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.