Print this page
9803 pbchk could use a -c option
9825 pbchk -b option should be -p

Split Close
Expand all
Collapse all
          --- old/usr/src/tools/scripts/git-pbchk.1onbld
          +++ new/usr/src/tools/scripts/git-pbchk.1onbld
↓ open down ↓ 4 lines elided ↑ open up ↑
   5    5  .\" You may only use this file in accordance with the terms of version
   6    6  .\" 1.0 of the CDDL.
   7    7  .\"
   8    8  .\" A full copy of the text of the CDDL should have accompanied this
   9    9  .\" source.  A copy of the CDDL is also available via the Internet at
  10   10  .\" http://www.illumos.org/license/CDDL.
  11   11  .\"
  12   12  .\"
  13   13  .\" Copyright 2011 Richard Lowe.
  14   14  .\" Copyright 2015 Elysium Digital, L.L.C.
       15 +.\" Copyright 2018 Joyent, Inc.
  15   16  .\"
  16   17  
  17      -.TH "GIT\-PBCHK" "1ONBLD" "April 23, 2015" "" ""
       18 +.TH "GIT\-PBCHK" "1ONBLD" "September 4, 2018" "" ""
  18   19  
  19   20  .SH "NAME"
  20   21  \fBgit\-pbchk\fR \- nits and pre\-putback checks for git
  21   22  
  22   23  .SH "SYNOPSIS"
  23      -git\-pbchk [\-b \fIbranch\fR]
       24 +git\-pbchk [\-c \fIcheck\fR] [\-p \fIbranch\fR] [file...]
  24   25  
  25   26  .P
  26      -git\-nits [\-b \fIbranch\fR]
       27 +git\-nits [\-c \fIcheck\fR] [\-p \fIbranch\fR] [file...]
  27   28  
       29 +.SH "OPTIONS"
       30 +
       31 +.TP
       32 +\fB\-c check\fR:
       33 +.IP
       34 +Run the specific \fIcheck\fR, as named below.
       35 +In this mode, individual files can be provided to check.
       36 +.TP
       37 +\fB\-p branch\fR:
       38 +.IP
       39 +Compare the current workspace to the parent \fIbranch\fR for the purposes of generating file and comment lists\.
       40 +.IP
       41 +If this option is not specified an attempt is made to determine this automatically, if the git branch configuration contains this information\.
       42 +.IP
       43 +If no branch is specified and none can be determined automatically \fBorigin/master\fR is used\.
  28   44  .SH "DESCRIPTION"
  29   45  Check your workspace for common nits and putback\-ending mistakes, a simple set of checks are run over various parts of your workspace and errors encountered are reported, all of which should, generally, be fixed\.
  30      -
  31   46  .TP
  32      -Comment format
       47 +Comment format [comchk]
  33   48  Check that putback comments follow the prescribed format (only run for pbchk)
  34      -
  35   49  .TP
  36      -Copyrights
       50 +Copyrights [copyright]
  37   51  Check that each source file contains a copyright notice for the current
  38   52  year\. You don't need to fix this if you, the potential new copyright holder, chooses not to
  39      -
  40   53  .TP
  41      -C style
       54 +C style [cstyle]
  42   55  Check that C source files conform to the Illumos C style rules
  43      -
  44   56  .TP
  45      -Header check
       57 +Header check [hdrchk]
  46   58  Check that C header files conform to the Illumos header style rules (in addition to the general C rules)
  47      -
  48   59  .TP
  49      -Java style
       60 +Java style [jstyle]
  50   61  Check that Java source files conform to the Illumos Java style rules (which differ from the traditionally recommended Java style)
  51      -
  52   62  .TP
  53      -SCCS Keywords
       63 +SCCS Keywords [keywords]
  54   64  Check that no source files contain unexpanded SCCS keywords\. It is possible that this check may false positive on certain inputs\. It is generally obvious when this is the case\.
  55      -
  56   65  .IP
  57   66  This check does not check for expanded SCCS keywords, though the common \'ident\'\-style lines should be removed regardless of whether they are expanded\.
  58      -
  59   67  .TP
  60      -Mapfile check
       68 +Man page check [manlint]
       69 +Check for problems with man pages.
       70 +.TP
       71 +Mapfile check [mapfilechk]
  61   72  Check that linker mapfiles contain a comment directing anyone editing to read the directions in \fBusr/lib/README\.mapfiles\fR\.
  62      -
  63      -.SH "OPTIONS"
  64      -
  65   73  .TP
  66      -\fB\-b branch\fR:
  67      -
  68      -.IP
  69      -Compare the current workspace to /branch/ for the purposes of generating file and comment lists\.
  70      -
  71      -.IP
  72      -If this option is not specified an attempt is made to determine this automatically, if the git branch configuration contains this information\.
  73      -
  74      -.IP
  75      -If no branch is specified and none can be determined automatically \fBorigin/master\fR is used\.
  76      -
       74 +Whitespace check [wscheck]
       75 +Check for whitespace issues such as mixed tabs/spaces in source files.
  77   76  .SH "FILES"
  78      -\fBgit nits\fR and \fBgit pbchk\fR support NOT files of the form used by Cadmium with Mercurial\. These are looked for in \fB$CODEMGR_WS/\.git/\fR and in \fB$CODEMGR_WS/exception_lists/\fR as normal\. The files are named after the check from which they exclude files\.
       77 +Exception lists can be used to exclude certain files from checking, named after
       78 +the specific check.
       79 +They can be found in \fB$CODEMGR_WS/exception_lists/\fR, or optionally under
       80 +\fB$CODEMGR_WS/\.git/\fR, where they must be suffixed \fB.NOT\fR.
  79   81  
  80      -.IP "\(bu" 4
  81      -\fBcopyright\.NOT\fR: exclude files listed from copyright checking
  82      -
  83      -.IP "\(bu" 4
  84      -\fBcstyle\.NOT\fR: exclude files from the C style check
  85      -
  86      -.IP "\(bu" 4
  87      -\fBhdrchk\.NOT\fR: exclude files from the C header style check
  88      -
  89      -.IP "\(bu" 4
  90      -\fBkeywords\.NOT\fR: exclude files from the SCCS keywords check
  91      -
  92      -.IP "\(bu" 4
  93      -\fBmapfilechk\.NOT\fR: exclude files from the linker mapfile check
  94      -
  95   82  .IP "" 0
  96   83  
    
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX