Code Review for illumos-gate

Prepared by:John Levon on 2018-Jun-14 17:16 +0100 BST
Workspace:/root/illumos-gate (at bc35195903d5)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at 14b24e2b7929)
Summary of changes: 381 lines changed: 222 ins; 128 del; 31 mod; 8888 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-test-ostest.mf

9600 LDT still not happy under KPTI
3 lines changed: 2 ins; 0 del; 1 mod; 75 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/runfiles/default.run

9600 LDT still not happy under KPTI
6 lines changed: 5 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/tests/Makefile

9600 LDT still not happy under KPTI
4 lines changed: 2 ins; 0 del; 2 mod; 18 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/os-tests/tests/i386/Makefile

9600 LDT still not happy under KPTI
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/os-tests/tests/i386/ldt.c

9600 LDT still not happy under KPTI
80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/test-runner/cmd/run

9600 LDT still not happy under KPTI
6 lines changed: 6 ins; 0 del; 0 mod; 886 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/proc.h

9600 LDT still not happy under KPTI
3 lines changed: 1 ins; 0 del; 2 mod; 824 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/ml/offsets.in

9600 LDT still not happy under KPTI
2 lines changed: 0 ins; 2 del; 0 mod; 511 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mlsetup.c

9600 LDT still not happy under KPTI
5 lines changed: 0 ins; 5 del; 0 mod; 537 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mp_startup.c

9600 LDT still not happy under KPTI
4 lines changed: 0 ins; 2 del; 2 mod; 2121 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/os/desctbls.c

9600 LDT still not happy under KPTI
107 lines changed: 40 ins; 65 del; 2 mod; 1381 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/os/sysi86.c

9600 LDT still not happy under KPTI
109 lines changed: 36 ins; 54 del; 19 mod; 831 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/segments.h

9600 LDT still not happy under KPTI
4 lines changed: 4 ins; 0 del; 0 mod; 723 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/x86_archext.h

9600 LDT still not happy under KPTI
2 lines changed: 0 ins; 0 del; 2 mod; 918 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.