Code Review for 2

Prepared by:John Levon on 2020-May-19 02:50 -0700 PDT
Workspace:/export/home/gk/src/2 (explicit head at ddd8c08e4d14)
Compare against: previous revision (at d5b4c61b9474)
Summary of changes: 1245 lines changed: 941 ins; 115 del; 189 mod; 34263 unchg
Patch of changes: 2.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/Makefile

12724 update smatch to 0.6.1-rc1-il-5
2 lines changed: 1 ins; 0 del; 1 mod; 268 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/Makefile

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 0 del; 1 mod; 391 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_all_func_returns.c

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 0 del; 1 mod; 87 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_allocating_enough_data.c

12724 update smatch to 0.6.1-rc1-il-5
5 lines changed: 4 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_atomic_inc_dec.c

12724 update smatch to 0.6.1-rc1-il-5
144 lines changed: 122 ins; 1 del; 21 mod; 226 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_debug.c

12724 update smatch to 0.6.1-rc1-il-5
64 lines changed: 54 ins; 9 del; 1 mod; 794 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_debug.h

12724 update smatch to 0.6.1-rc1-il-5
4 lines changed: 3 ins; 0 del; 1 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_err_ptr.c

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 1 del; 0 mod; 82 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_kernel.c

12724 update smatch to 0.6.1-rc1-il-5
37 lines changed: 26 ins; 5 del; 6 mod; 457 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_shift_to_zero.c

12724 update smatch to 0.6.1-rc1-il-5
2 lines changed: 0 ins; 0 del; 2 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/expression.h

12724 update smatch to 0.6.1-rc1-il-5
3 lines changed: 1 ins; 0 del; 2 mod; 332 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch.c

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 1 ins; 0 del; 0 mod; 368 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch.h

12724 update smatch to 0.6.1-rc1-il-5
34 lines changed: 27 ins; 3 del; 4 mod; 1413 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_bits.c

12724 update smatch to 0.6.1-rc1-il-5
74 lines changed: 48 ins; 21 del; 5 mod; 424 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_buf_size.c

12724 update smatch to 0.6.1-rc1-il-5
44 lines changed: 32 ins; 7 del; 5 mod; 947 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_capped.c

12724 update smatch to 0.6.1-rc1-il-5
7 lines changed: 4 ins; 2 del; 1 mod; 345 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_comparison.c

12724 update smatch to 0.6.1-rc1-il-5
2 lines changed: 0 ins; 0 del; 2 mod; 2794 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_container_of.c

12724 update smatch to 0.6.1-rc1-il-5
3 lines changed: 0 ins; 0 del; 3 mod; 644 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/db/create_db.sh

12724 update smatch to 0.6.1-rc1-il-5
3 lines changed: 2 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/db/kernel.return_fixes

12724 update smatch to 0.6.1-rc1-il-5
11 lines changed: 11 ins; 0 del; 0 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/db/mark_function_ptrs_searchable.pl

12724 update smatch to 0.6.1-rc1-il-5
11 lines changed: 0 ins; 11 del; 0 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/db/mtag_about.schema

12724 update smatch to 0.6.1-rc1-il-5
10 lines changed: 9 ins; 0 del; 1 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/tools/smatch/src/smatch_data/db/mtag_info.schema

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/db/mtag_map.schema

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 0 del; 1 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/db/return_states.schema

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 0 del; 1 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/db/smdb.py

12724 update smatch to 0.6.1-rc1-il-5
6 lines changed: 5 ins; 0 del; 1 mod; 791 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_db.c

12724 update smatch to 0.6.1-rc1-il-5
166 lines changed: 141 ins; 0 del; 25 mod; 2652 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_estate.c

12724 update smatch to 0.6.1-rc1-il-5
22 lines changed: 22 ins; 0 del; 0 mod; 460 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_expressions.c

12724 update smatch to 0.6.1-rc1-il-5
2 lines changed: 0 ins; 0 del; 2 mod; 331 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_extra.c

12724 update smatch to 0.6.1-rc1-il-5
34 lines changed: 11 ins; 13 del; 10 mod; 2934 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_extra.h

12724 update smatch to 0.6.1-rc1-il-5
4 lines changed: 4 ins; 0 del; 0 mod; 238 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_flow.c

12724 update smatch to 0.6.1-rc1-il-5
11 lines changed: 3 ins; 3 del; 5 mod; 1936 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_fresh_alloc.c

12724 update smatch to 0.6.1-rc1-il-5
24 lines changed: 24 ins; 0 del; 0 mod; 195 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_function_hooks.c

12724 update smatch to 0.6.1-rc1-il-5
45 lines changed: 40 ins; 1 del; 4 mod; 1259 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_function_ptrs.c

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 0 del; 1 mod; 461 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_helper.c

12724 update smatch to 0.6.1-rc1-il-5
64 lines changed: 33 ins; 5 del; 26 mod; 1211 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_implied.c

12724 update smatch to 0.6.1-rc1-il-5
91 lines changed: 75 ins; 1 del; 15 mod; 1163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_kernel_user_data.c

12724 update smatch to 0.6.1-rc1-il-5
15 lines changed: 0 ins; 15 del; 0 mod; 1539 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_math.c

12724 update smatch to 0.6.1-rc1-il-5
24 lines changed: 22 ins; 0 del; 2 mod; 1895 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_mtag.c

12724 update smatch to 0.6.1-rc1-il-5
70 lines changed: 35 ins; 15 del; 20 mod; 419 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_mtag_data.c

12724 update smatch to 0.6.1-rc1-il-5
58 lines changed: 57 ins; 0 del; 1 mod; 287 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_mtag_map.c

12724 update smatch to 0.6.1-rc1-il-5
7 lines changed: 1 ins; 0 del; 6 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_param_to_mtag_data.c

12724 update smatch to 0.6.1-rc1-il-5
3 lines changed: 1 ins; 0 del; 2 mod; 218 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_real_absolute.c

12724 update smatch to 0.6.1-rc1-il-5
5 lines changed: 5 ins; 0 del; 0 mod; 147 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_return_to_param.c

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 1 del; 0 mod; 239 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_scripts/build_kernel_data.sh

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 1 ins; 0 del; 0 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_scripts/summarize_errs.sh

12724 update smatch to 0.6.1-rc1-il-5
3 lines changed: 0 ins; 0 del; 3 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_slist.c

12724 update smatch to 0.6.1-rc1-il-5
3 lines changed: 3 ins; 0 del; 0 mod; 1088 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_states.c

12724 update smatch to 0.6.1-rc1-il-5
59 lines changed: 59 ins; 0 del; 0 mod; 1179 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_struct_assignment.c

12724 update smatch to 0.6.1-rc1-il-5
7 lines changed: 6 ins; 1 del; 0 mod; 578 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_type.c

12724 update smatch to 0.6.1-rc1-il-5
46 lines changed: 44 ins; 0 del; 2 mod; 861 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_type_val.c

12724 update smatch to 0.6.1-rc1-il-5
2 lines changed: 2 ins; 0 del; 0 mod; 686 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/token.h

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 1 ins; 0 del; 0 mod; 255 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/tokenize.c

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 0 del; 1 mod; 1031 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/validation/sm_impossible1.c

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 0 del; 1 mod; 24 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/validation/sm_impossible2.c

12724 update smatch to 0.6.1-rc1-il-5
1 line changed: 0 ins; 0 del; 1 mod; 24 unchg

This code review page was prepared using /export/home/gk/src/grot/cwebrev. Webrev is maintained by the illumos project. The latest version may be obtained here.