Print this page
10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/mdb/common/mdb/mdb_nm.c
          +++ new/usr/src/cmd/mdb/common/mdb/mdb_nm.c
↓ open down ↓ 15 lines elided ↑ open up ↑
  16   16   * fields enclosed by brackets "[]" replaced with your own identifying
  17   17   * information: Portions Copyright [yyyy] [name of copyright owner]
  18   18   *
  19   19   * CDDL HEADER END
  20   20   */
  21   21  /*
  22   22   * Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
  23   23   * Use is subject to license terms.
  24   24   */
  25   25  
       26 +/*
       27 + * Copyright (c) 2018, Joyent, Inc.
       28 + */
       29 +
  26   30  #include <sys/elf.h>
  27   31  #include <sys/elf_SPARC.h>
  28   32  
  29   33  #include <libproc.h>
  30   34  #include <libctf.h>
  31   35  #include <stdlib.h>
  32   36  #include <string.h>
  33   37  #include <fcntl.h>
  34   38  #include <errno.h>
  35   39  
↓ open down ↓ 742 lines elided ↑ open up ↑
 778  782                  callback = nm_asgn;
 779  783          else if (optf & NM_UNDEF)
 780  784                  callback = nm_undef;
 781  785          else
 782  786                  callback = nm_any;
 783  787  
 784  788          if (optf & (NM_SORT_NAME | NM_SORT_VALUE)) {
 785  789                  for (symp = syms; nsyms-- != 0; symp++) {
 786  790                          nii.nii_fp = symp->nm_fp;
 787  791  
 788      -                        callback(&nii, &symp->nm_sym, symp->nm_name,
      792 +                        (void) callback(&nii, &symp->nm_sym, symp->nm_name,
 789  793                              &symp->nm_si, symp->nm_object);
 790  794                  }
 791  795  
 792  796          } else {
 793  797                  if (optf & NM_PRVSYM) {
 794  798                          nm_gelf_symtab_iter(mdb.m_prsym, object, MDB_TGT_PRVSYM,
 795  799                              callback, &nii);
 796  800  
 797  801                  } else if (nm_symbol_iter(object, which, type, callback, &nii)
 798  802                      == -1) {
↓ open down ↓ 116 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX