Print this page
10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/mdb/common/mdb/mdb.c
          +++ new/usr/src/cmd/mdb/common/mdb/mdb.c
↓ open down ↓ 16 lines elided ↑ open up ↑
  17   17   * information: Portions Copyright [yyyy] [name of copyright owner]
  18   18   *
  19   19   * CDDL HEADER END
  20   20   */
  21   21  /*
  22   22   * Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  23   23   * Use is subject to license terms.
  24   24   */
  25   25  /*
  26   26   * Copyright (c) 2012 by Delphix. All rights reserved.
  27      - * Copyright (c) 2012 Joyent, Inc. All rights reserved.
       27 + * Copyright (c) 2018, Joyent, Inc.
  28   28   */
  29   29  
  30   30  /*
  31   31   * Modular Debugger (MDB)
  32   32   *
  33   33   * Refer to the white paper "A Modular Debugger for Solaris" for information
  34   34   * on the design, features, and goals of MDB.  See /shared/sac/PSARC/1999/169
  35   35   * for copies of the paper and related documentation.
  36   36   *
  37   37   * This file provides the basic construction and destruction of the debugger's
↓ open down ↓ 1110 lines elided ↑ open up ↑
1148 1148          return (status);
1149 1149  }
1150 1150  
1151 1151  void
1152 1152  mdb_call_tab(mdb_idcmd_t *idcp, mdb_tab_cookie_t *mcp, uint_t flags,
1153 1153      uintmax_t argc, mdb_arg_t *argv)
1154 1154  {
1155 1155          if (idcp->idc_tabp == NULL)
1156 1156                  return;
1157 1157  
1158      -        idcp->idc_tabp(mcp, flags, argc, argv);
     1158 +        (void) idcp->idc_tabp(mcp, flags, argc, argv);
1159 1159  }
1160 1160  
1161 1161  /*
1162 1162   * Call an internal dcmd directly: this code is used by module API functions
1163 1163   * that need to execute dcmds, and by mdb_call() above.
1164 1164   */
1165 1165  int
1166 1166  mdb_call_idcmd(mdb_idcmd_t *idcp, uintmax_t addr, uintmax_t count,
1167 1167      uint_t flags, mdb_argvec_t *avp, mdb_addrvec_t *adp, mdb_vcb_t *vcbs)
1168 1168  {
↓ open down ↓ 245 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX