10080 smatch Makefile changes for usr/src/cmd

          --- old/usr/src/cmd/sa/Makefile
          +++ new/usr/src/cmd/sa/Makefile

   1    1  #
   2    2  # CDDL HEADER START
   3    3  #
   4    4  # The contents of this file are subject to the terms of the
   5    5  # Common Development and Distribution License (the "License").
   6    6  # You may not use this file except in compliance with the License.
   7    7  #
   8    8  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
   9    9  # or http://www.opensolaris.org/os/licensing.
  10   10  # See the License for the specific language governing permissions
  11   11  # and limitations under the License.
  12   12  #
  13   13  # When distributing Covered Code, include this CDDL HEADER in each
  14   14  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  15   15  # If applicable, add the following below this CDDL HEADER, with the

  16   16  # fields enclosed by brackets "[]" replaced with your own identifying
  17   17  # information: Portions Copyright [yyyy] [name of copyright owner]
  18   18  #
  19   19  # CDDL HEADER END
  20   20  #
  21   21  #
  22   22  # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  23   23  # Use is subject to license terms.
  24   24  # Copyright (c) 2013 Andrew Stormont.  All rights reserved.
  25   25  #
  26      -# cmd/sa/Makefile
  27      -#
       26 +# Copyright (c) 2018, Joyent, Inc.
  28   27  
  29   28  MANIFEST =      sar.xml
  30   29  SVCMETHOD =     svc-sar
  31   30  
  32   31  include ../Makefile.cmd
  33   32  
  34   33  ROOTMANIFESTDIR = $(ROOTSVCSYSTEM)
  35   34  
  36   35  CERRWARN +=     -_gcc=-Wno-parentheses
  37   36  CERRWARN +=     -_gcc=-Wno-uninitialized
  38   37  
       38 +SMOFF += all_func_returns
       39 +
  39   40  GREP=           grep
  40   41  
  41   42  SADC=           sadc
  42   43  SAR=            sar
  43   44  TIMEX=          timex
  44   45  SA1=            sa1
  45   46  SA2=            sa2
  46   47  
  47   48  sadc :=         LDLIBS += -lkstat
  48   49  

  49   50  # Executables produced
  50   51  BINPROG=        $(TIMEX)
  51   52  SBINPROG=       $(SAR)
  52   53  LIBPROG=        $(SADC)
  53   54  LIBSHELL=       $(SA1) $(SA2)
  54   55  INITSHELL=      $(PERF)
  55   56  
  56   57  PROGS=          $(BINPROG) $(SBINPROG) $(LIBPROG)
  57   58  SHELLS=         $(LIBSHELL)
  58   59  TXTS=           README
  59   60  ALL=            $(PROGS) $(SHELLS)
  60   61  
  61   62  # Source files
  62   63  SADC_OBJECTS=   $(SADC).o
  63   64  srcs=           $(TIMEX) $(SAR) $(SADC)
  64   65  SRCS=           $(srcs:%=%.c)
  65   66  SHSRCS=         $(SHELLS:%=%.sh)
  66   67  
  67   68  # Set of target install directories
  68   69  LIBSAD=         $(ROOT)/usr/lib/sa
  69   70  CROND=          $(ROOT)/var/spool/cron
  70   71  CRONTABSD=      $(CROND)/crontabs
  71   72  
  72   73  # Set of target install files
  73   74  SYSCRONTAB=     $(CRONTABSD)/sys
  74   75  ROOTPROG=       $(BINPROG:%=$(ROOTBIN)/%)
  75   76  ROOTUSBINPROG=  $(SBINPROG:%=$(ROOTUSRSBIN)/%)
  76   77  ROOTLIBPROG=    $(LIBPROG:%=$(LIBSAD)/%)
  77   78  ROOTLIBSHELL=   $(LIBSHELL:%=$(LIBSAD)/%)
  78   79  ROOTSYMLINKS=   $(SBINPROG:%=$(ROOTBIN)/%)
  79   80  
  80   81  # Performance monitoring should not be enabled by default. Hence, these
  81   82  # entries are comments.
  82   83  ENTRY1=         '$(POUND_SIGN) 0 * * * 0-6 /usr/lib/sa/sa1'
  83   84  ENTRY2=         '$(POUND_SIGN) 20,40 8-17 * * 1-5 /usr/lib/sa/sa1'
  84   85  ENTRY3=         '$(POUND_SIGN) 5 18 * * 1-5 /usr/lib/sa/sa2 -s 8:00 -e 18:01 -i 1200 -A'
  85   86  
  86   87  CLOBBERFILES=   $(PROGS) $(SHELLS)
  87   88  
  88   89  # Conditionals
  89   90  $(LIBSAD)/$(SADC)       := FILEMODE = 0555
  90   91  
  91   92  .KEEP_STATE:
  92   93  
  93   94  all:            $(ALL) $(TXTS)
  94   95  
  95   96  $(SADC):        $(SADC_OBJECTS)
  96   97          $(LINK.c) -o $@ $(SADC_OBJECTS) $(LDLIBS)
  97   98          $(POST_PROCESS)
  98   99  
  99  100  # The edit of SYSCRONTAB must be done unconditionally because of the
 100  101  # creation of this file by a different component (Adm) and the possible
 101  102  # backdating.
 102  103  install:        all $(ROOTPROG) $(ROOTUSBINPROG)     \
 103  104                  $(ROOTINITSHELL)  $(ROOTLIBSHELL) $(ROOTSYMLINKS) \
 104  105                  $(ROOTMANIFEST) $(ROOTSVCMETHOD) $(ROOTLIBPROG)
 105  106          @if [ -f $(SYSCRONTAB) ]; \
 106  107          then \
 107  108                  if $(GREP) "sa1" $(SYSCRONTAB) >/dev/null 2>&1 ; then :; \
 108  109                  else \
 109  110                          echo $(ENTRY1) >> $(SYSCRONTAB); \
 110  111                          echo $(ENTRY2) >> $(SYSCRONTAB); \
 111  112                          echo "$(SYSCRONTAB) modified"; \
 112  113                  fi; \
 113  114                  if $(GREP) "sa2" $(SYSCRONTAB) >/dev/null 2>&1 ; then :; \
 114  115                  else \
 115  116                          echo $(ENTRY3) >> $(SYSCRONTAB); \
 116  117                  fi; \
 117  118          fi
 118  119  
 119  120  $(LIBSAD)/%: %
 120  121          $(INS.file)
 121  122  
 122  123  $(ROOTSYMLINKS):
 123  124          -$(RM) $@; $(SYMLINK) ../sbin/`basename $@` $@
 124  125  
 125  126  $(ETCINITD)/%: %
 126  127          $(INS.file)
 127  128  
 128  129  check:  $(CHKMANIFEST)
 129  130  
 130  131  clean:
 131  132          $(RM) $(SADC_OBJECTS) $(PROGS) $(SHELLS)
 132  133  
 133  134  lint:   lint_SRCS
 134  135  
 135  136  include ../Makefile.targ

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX