5910 libnisdb won't build with modern GCC

@@ -17,10 +17,11 @@
  * information: Portions Copyright [yyyy] [name of copyright owner]
  *
  * CDDL HEADER END
  */
 /*
+ * Copyright 2015 Gary Mills
  * Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
 
 #include <synch.h>

@@ -513,11 +514,10 @@
         LDAP                    *ld;
         int                     ldapVersion = LDAP_VERSION3;
         int                     derefOption = LDAP_DEREF_ALWAYS;
         int                     timelimit = proxyInfo.search_time_limit;
         int                     sizelimit = proxyInfo.search_size_limit;
-        char                    *myself = "ldapInit";
 
         if (srv == 0)
                 return (0);
 
         if (use_ssl) {

@@ -616,11 +616,10 @@
  * Return LDAP_UNAVAILABLE upon success, in which case the caller mustn't
  * try to use the structure pointer in any way.
  */
 static int
 freeCon(__nis_ldap_conn_t *lc) {
-        char                    *myself = "freeCon";
 
         if (!assertExclusive(lc))
                 return (LDAP_PARAM_ERROR);
 
         incrementRC(lc);

@@ -1032,11 +1031,11 @@
                 (void) rw_unlock(&ldapConLock);
                 return (LDAP_NO_MEMORY);
         }
 
         /* Remove leading white space */
-        for (0; *sl == ' ' || *sl == '\t'; sl++);
+        for (; *sl == ' ' || *sl == '\t'; sl++);
 
         /* Create connection for each server on the list */
         for (s = sl; *s != '\0'; s = e+1) {
                 int     l;
 

@@ -2225,11 +2224,10 @@
         int                     stat, add = 0;
         LDAPMod                 **mods = 0;
         __nis_ldap_conn_t       *lc;
         struct timeval          tv;
         LDAPMessage             *msg = 0;
-        char                    *myself = "ldapModify";
         int                     msgid;
         int                     lderr;
         char                    **referralsp = NULL;
         bool_t                  delete = FALSE;