Code Review for illumos-extra

Prepared by:Joshua M. Clulow (jclulow) on 2013-Oct-07 21:44 +0000 UTC
Workspace:/ws/illumos-extra (at e0f9b19f9056)
Compare against: e0f9b19^ (at fd58cc85d5ea)
Summary of changes: 65 lines changed: 64 ins; 0 del; 1 mod; 1552 unchg
Patch of changes: illumos-extra.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw cpp/cpp.c

cpp: squash spaces correctly-ish whilst pasting macros
Sun cpp removes all leading and trailing space from a macro pasting, and
compress whitespace in the macro body to a single space character.
There is some deviation from this in the Sun implementation which we
don't duplicate.
1) The presence of comments in the macro body affect the minimization of
   runs of spaces.
2) When newlines are encountered in the parameter list of a macro
   invocation, Sun cpp inserts that many newlines prior to any of the
   pasted text, and then in the pasted text pastes those newlines as
   (minimized) spaces.  Escaped new-lines are de-escaped, and otherwise
   treated similarly (in effect, the \ is removed).
65 lines changed: 64 ins; 0 del; 1 mod; 1552 unchg

This code review page was prepared using /ws/dplat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.