Code Review for illumos

Prepared by:Joshua M. Clulow (jclulow) on 2012-Nov-26 00:31 +0000 UTC
Workspace:/ws/plat/projects/illumos (at c67bd2ca0602)
Compare against: origin/master (git://github.com/joyent/illumos-joyent at f127c3d31417)
Summary of changes: 1144 lines changed: 1055 ins; 38 del; 51 mod; 52296 unchg
Patch of changes: illumos.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw manifest

LOCAL: preliminary topo mapping for Richmond-A disk bays
2 lines changed: 2 ins; 0 del; 0 mod; 16972 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/mpt_sas/mpt_sas.c

LOCAL: mpt_sas target should show enclosure/slot IDs
4 lines changed: 2 ins; 0 del; 2 mod; 844 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/topo_hc.h

LOCAL: expose mptsas leds as topo facilities - attempt 1
4 lines changed: 4 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/topo_xml.c

LOCAL: libtopo obsessed with fac_prov_ipmi
19 lines changed: 2 ins; 13 del; 4 mod; 2130 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/fm/topo/maps/Joyent,Joyent-Compute-Platform-1101/Joyent-Compute-Platform-1101-disk-hc-topology.xmlgenksh

LOCAL: preliminary topo mapping for Richmond-A disk bays
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

new executable file: mode 755

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/fm/topo/maps/Joyent,Joyent-Compute-Platform-1101/Makefile

LOCAL: preliminary topo mapping for Richmond-A disk bays
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/maps/Makefile

LOCAL: preliminary topo mapping for Richmond-A disk bays
2 lines changed: 1 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/maps/Makefile.map

LOCAL: preliminary topo mapping for Richmond-A disk bays
8 lines changed: 6 ins; 1 del; 1 mod; 87 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/fm/topo/maps/common/xmlgen-header-new.xml

LOCAL: cleanup before webrev
2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/maps/i86pc/i86pc-legacy-hc-topology.xml

LOCAL: preliminary topo mapping for Richmond-A disk bays
13 lines changed: 13 ins; 0 del; 0 mod; 170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/common/Makefile

LOCAL: expose mptsas leds as topo facilities - attempt 1
2 lines changed: 1 ins; 1 del; 0 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/common/disk/Makefile

LOCAL: fma: enumerate static mpt_sas disk mappings
4 lines changed: 2 ins; 1 del; 1 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/common/disk/disk.c

LOCAL: fma: enumerate static mpt_sas disk mappings
42 lines changed: 41 ins; 0 del; 1 mod; 146 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/common/disk/disk.h

LOCAL: fma: enumerate static mpt_sas disk mappings
1 line changed: 1 ins; 0 del; 0 mod; 104 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/fm/topo/modules/common/disk/disk_mptsas.c

LOCAL: cleanup before webrev
117 lines changed: 117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/fm/topo/modules/common/fac_prov_mptsas/Makefile

LOCAL: expose mptsas leds as topo facilities - attempt 1
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/fm/topo/modules/common/fac_prov_mptsas/fac_prov_mptsas.c

LOCAL: expose mptsas leds as topo facilities - attempt 1
233 lines changed: 233 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/vdev_disk.h

LOCAL: listen for ldi notifications of disk offline/degrade
4 lines changed: 3 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/vdev_disk.c

LOCAL: listen for ldi notifications of disk offline/degrade
221 lines changed: 203 ins; 2 del; 16 mod; 657 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas.c

LOCAL: mpt_sas: expose drive ID via ioctl
210 lines changed: 169 ins; 20 del; 21 mod; 16158 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/devcfg.c

LOCAL: devfs_clean before trying to offline to release refs to dev_info
7 lines changed: 7 ins; 0 del; 0 mod; 9187 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/driver_lyr.c

LOCAL: LDI -- make walks removal-safe
22 lines changed: 19 ins; 0 del; 3 mod; 3717 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/scsi/adapters/mpt_sas/mptsas_ioctl.h

LOCAL: mpt_sas: expose drive ID via ioctl
52 lines changed: 52 ins; 0 del; 0 mod; 303 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/scsi/adapters/mpt_sas/mptsas_var.h

LOCAL: mpt_sas: store LED state, expose via ioctl
2 lines changed: 2 ins; 0 del; 0 mod; 1471 unchg

This code review page was prepared using /ws/plat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.