Code Review for dplat

Prepared by:Joshua M. Clulow (jclulow) on 2013-Oct-21 19:08 +0000 UTC
Workspace:/ws/dplat (at d7e72cecb552)
Compare against: HEAD^ (at 974cc275c2bc)
Summary of changes: 4971 lines changed: 4965 ins; 0 del; 6 mod; 1435 unchg
Patch of changes: dplat.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw Makefile

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
3 lines changed: 0 ins; 0 del; 3 mod; 234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/Makefile

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
32 lines changed: 32 ins; 0 del; 0 mod; 555 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/Makefile.defs

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
10 lines changed: 7 ins; 0 del; 3 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/manifest

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
2 lines changed: 2 ins; 0 del; 0 mod; 561 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/.gitignore

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/LICENSE

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
18 lines changed: 18 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/README.md

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/lib/index.js

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/.npmignore

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/Makefile.v8plus.defs

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/Makefile.v8plus.targ

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/README.md

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
871 lines changed: 871 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/examples/Makefile

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
21 lines changed: 21 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/examples/errno.json

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
19 lines changed: 19 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/examples/example.c

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
336 lines changed: 336 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/examples/example.h

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/examples/test.js

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/generrno.js

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
229 lines changed: 229 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/node_modules/posix-getopt/LICENSE

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
19 lines changed: 19 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/node_modules/posix-getopt/README.md

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
244 lines changed: 244 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/node_modules/posix-getopt/examples/examples.js

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/node_modules/posix-getopt/lib/getopt.js

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
304 lines changed: 304 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/node_modules/posix-getopt/package.json

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/node_modules/posix-getopt/tests/test-getopt.js

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/node_modules/posix-getopt/tests/test-tokenize-optstr.js

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/origin.js

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
7 lines changed: 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/package.json

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/v8plus_csup.c

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
829 lines changed: 829 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/v8plus_glue.h

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
220 lines changed: 220 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/v8plus_impl.h

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/v8plus_objectwrap.cc

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
321 lines changed: 321 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/node_modules/v8plus/v8plus_subr.cc

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
647 lines changed: 647 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/package.json

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/src/Makefile

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/src/errno.json

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/node-lockfd/src/lockfd.c

OS-2552 add node-lockfd (v0.0.2) to platform
OS-2558 smartos-live should run tools from proto.strap, not proto
143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /ws/dplat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.