Code Review for illumos

Prepared by:Joshua M. Clulow (jclulow) on 2013-Jul-19 00:05 +0000 UTC
Workspace:/ws/dplat/projects/illumos (at 326eb07f3bc7)
Compare against: origin/master (git://github.com/joyent/illumos-joyent.git at 5c0519e0a200)
Summary of changes: 1124 lines changed: 284 ins; 625 del; 215 mod; 18170 unchg
Patch of changes: illumos.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/Makefile.files

OS-2366 ddi_periodic_add(9F) is entirely rubbish
2 lines changed: 2 ins; 0 del; 0 mod; 77 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mdb/common/modules/genunix/ddi_periodic.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mdb/common/modules/genunix/ddi_periodic.h

OS-2366 ddi_periodic_add(9F) is entirely rubbish
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/genunix.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
5 lines changed: 4 ins; 0 del; 1 mod; 4587 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/clock.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
11 lines changed: 0 ins; 9 del; 2 mod; 2664 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/ddi_timer.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
847 lines changed: 126 ins; 551 del; 170 mod; 180 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/main.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
5 lines changed: 4 ins; 0 del; 1 mod; 649 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ddi_timer.h

OS-2366 ddi_periodic_add(9F) is entirely rubbish
93 lines changed: 5 ins; 65 del; 23 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/apix/apix.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
17 lines changed: 11 ins; 0 del; 6 mod; 2550 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/pcplusmp/apic.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
21 lines changed: 16 ins; 0 del; 5 mod; 1381 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/pcplusmp/apic_common.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
4 lines changed: 3 ins; 0 del; 1 mod; 1724 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/startup.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
8 lines changed: 4 ins; 0 del; 4 mod; 3232 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/apic_common.h

OS-2366 ddi_periodic_add(9F) is entirely rubbish
5 lines changed: 4 ins; 0 del; 1 mod; 199 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/os/intr.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
5 lines changed: 4 ins; 0 del; 1 mod; 868 unchg

This code review page was prepared using /ws/dplat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.