Code Review for illumos

Prepared by:Joshua M. Clulow (jclulow) on 2013-Jan-29 05:16 +0000 UTC
Workspace:/ws/plat/projects/illumos (at 2041d4ded972)
Compare against: 7662d3a8db7e (at 7662d3a8db7e)
Summary of changes: 267 lines changed: 95 ins; 26 del; 146 mod; 1777 unchg
Patch of changes: illumos.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/Makefile.com

OS-1840 fmdump shall emit JSON (rm feedback)
1 line changed: 0 ins; 1 del; 0 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/nvlrender.c

OS-1840 fmdump shall emit JSON (newlines, fflush)
5 lines changed: 3 ins; 0 del; 2 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/nvpair/fnvpair.c

OS-1840 fmdump shall emit JSON (copyright fixes 2)
OS-1840 fmdump shall emit JSON (rm feedback)
22 lines changed: 20 ins; 0 del; 2 mod; 494 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/Makefile.com

OS-1840 fmdump shall emit JSON (rm feedback)
6 lines changed: 6 ins; 0 del; 0 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/libnvpair.h

OS-1840 fmdump shall emit JSON (rm feedback)
1 line changed: 0 ins; 0 del; 1 mod; 195 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/mapfile-vers

OS-1840 fmdump shall emit JSON (rm feedback)
7 lines changed: 7 ins; 0 del; 0 mod; 291 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/nvpair_json.c

OS-1840 fmdump shall emit JSON (newlines, fflush)
OS-1840 fmdump shall emit JSON (small fix 3)
OS-1840 fmdump shall emit JSON (small fix 2)
OS-1840 fmdump shall emit JSON (rm feedback)
218 lines changed: 54 ins; 25 del; 139 mod; 203 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/nvpair.h

OS-1840 fmdump shall emit JSON (copyright fixes 2)
OS-1840 fmdump shall emit JSON (rm feedback)
7 lines changed: 5 ins; 0 del; 2 mod; 348 unchg

This code review page was prepared using /ws/plat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.