Code Review for rich

Prepared by:Jason King on 2018-Feb-27 22:54 -0600 CST
Workspace:/export/home/jason/illumos-gate (at bde01707f955)
Compare against: /export/home/jason/illumos-gate (explicit revision cd2654fbce77)
Summary of changes: 405 lines changed: 244 ins; 55 del; 106 mod; 57001 unchg
Patch of changes: rich.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/packaging

Rich's feedback
3 lines changed: 2 ins; 1 del; 0 mod; 1002 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/Makefile

Rich's feedback
3 lines changed: 2 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_util.c

Rich's feedback
4 lines changed: 0 ins; 1 del; 3 mod; 108 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/Makefile.mdb

Rich's feedback
2 lines changed: 1 ins; 0 del; 1 mod; 208 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_demangle.c

Rich's feedback
12 lines changed: 6 ins; 2 del; 4 mod; 326 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_demangle.h

Rich's feedback
2 lines changed: 0 ins; 0 del; 2 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/dump/common/dump.c

libconv
20 lines changed: 10 ins; 6 del; 4 mod; 2121 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/gprof/common/printgprof.c

libconv
27 lines changed: 9 ins; 7 del; 11 mod; 1040 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/common/demangle.c

libconv
36 lines changed: 0 ins; 25 del; 11 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/common/demangle.msg

libconv
3 lines changed: 0 ins; 0 del; 3 mod; 27 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/liblddbg/common/util.c

libconv
25 lines changed: 21 ins; 0 del; 4 mod; 353 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/nm/common/nm.c

libconv
11 lines changed: 5 ins; 4 del; 2 mod; 1506 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/prof/common/prof.c

libconv
5 lines changed: 2 ins; 2 del; 1 mod; 1368 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/prof/common/profv.c

libconv
3 lines changed: 2 ins; 0 del; 1 mod; 913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

Rich's feedback
5 lines changed: 3 ins; 2 del; 0 mod; 723 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/Makefile (renamed and modified from usr/src/lib/libsysdemangle/Makefile)

Rich's feedback
3 lines changed: 0 ins; 0 del; 3 mod; 38 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/Makefile.com

Rich's feedback
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdemangle/THIRDPARTYLICENSE (renamed from usr/src/lib/libsysdemangle/THIRDPARTYLICENSE)

Rich's feedback
0 lines changed: 0 ins; 0 del; 0 mod; 76 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdemangle/THIRDPARTYLICENSE.descrip (renamed from usr/src/lib/libsysdemangle/THIRDPARTYLICENSE.descrip)

Rich's feedback
0 lines changed: 0 ins; 0 del; 0 mod; 1 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdemangle/amd64/Makefile (renamed from usr/src/lib/libsysdemangle/amd64/Makefile)

Rich's feedback
0 lines changed: 0 ins; 0 del; 0 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/common/cxx.c (renamed and modified from usr/src/lib/libsysdemangle/common/cxx.c)

Rich's feedback
35 lines changed: 3 ins; 2 del; 30 mod; 4180 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/common/cxx.h (renamed and modified from usr/src/lib/libsysdemangle/common/cxx.h)

Rich's feedback
1 line changed: 0 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/common/cxx_util.c (renamed and modified from usr/src/lib/libsysdemangle/common/cxx_util.c)

Rich's feedback
6 lines changed: 0 ins; 0 del; 6 mod; 594 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/common/demangle-sys.h (renamed and modified from usr/src/lib/libsysdemangle/common/sysdemangle.h)

Rich's feedback
3 lines changed: 0 ins; 0 del; 3 mod; 38 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/demangle.c

Rich's feedback
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/common/demangle_int.h (renamed and modified from usr/src/lib/libsysdemangle/common/sysdemangle_int.h)

Rich's feedback
6 lines changed: 2 ins; 0 del; 4 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/common/llib-ldemangle-sys (renamed and modified from usr/src/lib/libsysdemangle/common/llib-lsysdemangle)

Rich's feedback
2 lines changed: 0 ins; 0 del; 2 mod; 27 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdemangle/common/mapfile-vers (renamed from usr/src/lib/libsysdemangle/common/mapfile-vers)

Rich's feedback
0 lines changed: 0 ins; 0 del; 0 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/common/str.c (renamed and modified from usr/src/lib/libsysdemangle/common/str.c)

Rich's feedback
1 line changed: 0 ins; 0 del; 1 mod; 312 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/common/str.h (renamed and modified from usr/src/lib/libsysdemangle/common/str.h)

Rich's feedback
2 lines changed: 0 ins; 0 del; 2 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdemangle/common/util.c (renamed and modified from usr/src/lib/libsysdemangle/common/util.c)

Rich's feedback
2 lines changed: 0 ins; 0 del; 2 mod; 83 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdemangle/i386/Makefile (renamed from usr/src/lib/libsysdemangle/i386/Makefile)

Rich's feedback
0 lines changed: 0 ins; 0 del; 0 mod; 30 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdemangle/sparc/Makefile (renamed from usr/src/lib/libsysdemangle/sparc/Makefile)

Rich's feedback
0 lines changed: 0 ins; 0 del; 0 mod; 30 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdemangle/sparcv9/Makefile (renamed from usr/src/lib/libsysdemangle/sparcv9/Makefile)

Rich's feedback
0 lines changed: 0 ins; 0 del; 0 mod; 29 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/system-library-demangle.mf

Rich's feedback
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/demangle/Makefile

Rich's feedback
3 lines changed: 0 ins; 0 del; 3 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/demangle/afl-fast.c

Rich's feedback
3 lines changed: 1 ins; 1 del; 1 mod; 2953 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/demangle/gcc-libstdc++.c

Rich's feedback
2 lines changed: 1 ins; 1 del; 0 mod; 8669 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/demangle/llvm-stdcxxabi.c

Rich's feedback
2 lines changed: 1 ins; 1 del; 0 mod; 29732 unchg

This code review page was prepared using /export/home/jason/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.