Code Review for illumos-gate

Prepared by:Super-User (root) on 2017-Jun-18 12:12 +0100 BST
Workspace:/root/illumos-gate (at 4dd937ac61a6)
Compare against: origin/master (git@github.com:illumos/illumos-gate.git at f15a6fde3c0a)
Summary of changes: 399 lines changed: 371 ins; 13 del; 15 mod; 9062 unchg
Patch of changes: illumos-gate.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

8411 Build should warn when linking against libraries outside proto area
19 lines changed: 14 ins; 5 del; 0 mod; 1170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile.cmd

8411 Build should warn when linking against libraries outside proto area
3 lines changed: 2 ins; 0 del; 1 mod; 509 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/availdevs/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/bootadm/Makefile

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/fiocompress/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cdrw/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/kmfcfg/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/tpmadm/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wanboot/p12split/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wanboot/wanboot-cgi/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wpad/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dfs.cmds/sharemgr/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/fabric-xlate/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/notify/snmp-notify/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/addons/acpi/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 4 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/addons/cpufreq/Makefile

8411 Build should warn when linking against libraries outside proto area
6 lines changed: 5 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/addons/network-devices/Makefile

8411 Build should warn when linking against libraries outside proto area
8 lines changed: 8 ins; 0 del; 0 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/addons/storage/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/hald-runner/Makefile

8411 Build should warn when linking against libraries outside proto area
6 lines changed: 5 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/hald/Makefile

8411 Build should warn when linking against libraries outside proto area
9 lines changed: 9 ins; 0 del; 0 mod; 89 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/probing/acpi/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 4 ins; 0 del; 1 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/probing/network-printer/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/probing/printer/Makefile

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 3 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/probing/storage/Makefile

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 3 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/probing/volume/Makefile

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 3 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/probing/xkb/Makefile

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/tools/Makefile

8411 Build should warn when linking against libraries outside proto area
7 lines changed: 7 ins; 0 del; 0 mod; 170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/tools/sunos/Makefile

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 3 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/isns/isnsadm/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/isns/isnsd/Makefile

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/latencytop/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/lp/filter/postscript/font/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 3 ins; 2 del; 0 mod; 89 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mandoc/Makefile

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oawk/Makefile

8411 Build should warn when linking against libraries outside proto area
3 lines changed: 3 ins; 0 del; 0 mod; 123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/policykit/Makefile

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmmount/Makefile

8411 Build should warn when linking against libraries outside proto area
7 lines changed: 7 ins; 0 del; 0 mod; 75 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmvolmgr/Makefile

8411 Build should warn when linking against libraries outside proto area
7 lines changed: 7 ins; 0 del; 0 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sendmail/src/Makefile

8411 Build should warn when linking against libraries outside proto area
6 lines changed: 6 ins; 0 del; 0 mod; 87 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/svccfg/Makefile

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 176 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/volcheck/Makefile

8411 Build should warn when linking against libraries outside proto area
7 lines changed: 7 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/volrmmount/Makefile

8411 Build should warn when linking against libraries outside proto area
7 lines changed: 7 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile.lib

8411 Build should warn when linking against libraries outside proto area
3 lines changed: 1 ins; 0 del; 2 mod; 254 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/libfmd_snmp/Makefile.com

8411 Build should warn when linking against libraries outside proto area
7 lines changed: 7 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/hal/libhal-storage/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/hal/libhal/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/krb5/plugins/preauth/pkinit/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libbrand/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libkmf/libkmf/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libkmf/plugins/kmf_nss/Makefile.com

8411 Build should warn when linking against libraries outside proto area
22 lines changed: 18 ins; 2 del; 2 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libkmf/plugins/kmf_openssl/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libldap5/Makefile.com

8411 Build should warn when linking against libraries outside proto area
16 lines changed: 15 ins; 0 del; 1 mod; 151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libldap5/amd64/Makefile

8411 Build should warn when linking against libraries outside proto area
1 line changed: 0 ins; 1 del; 0 mod; 15 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libldap5/i386/Makefile

8411 Build should warn when linking against libraries outside proto area
1 line changed: 0 ins; 1 del; 0 mod; 18 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libldap5/sparc/Makefile

8411 Build should warn when linking against libraries outside proto area
1 line changed: 0 ins; 1 del; 0 mod; 17 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libldap5/sparcv9/Makefile

8411 Build should warn when linking against libraries outside proto area
1 line changed: 0 ins; 1 del; 0 mod; 17 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libpool/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libscf/Makefile.com

8411 Build should warn when linking against libraries outside proto area
2 lines changed: 2 ins; 0 del; 0 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshare/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshare/autofs/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshare/nfs/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshare/smb/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshare/smbfs/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libuutil/Makefile.com

8411 Build should warn when linking against libraries outside proto area
2 lines changed: 2 ins; 0 del; 0 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libwanboot/Makefile.com

8411 Build should warn when linking against libraries outside proto area
6 lines changed: 6 ins; 0 del; 0 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzonecfg/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzpool/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/policykit/Makefile.com

8411 Build should warn when linking against libraries outside proto area
6 lines changed: 6 ins; 0 del; 0 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pylibbe/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pysolaris/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pyzfs/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ctf/dwarf/Makefile.com

8411 Build should warn when linking against libraries outside proto area
5 lines changed: 5 ins; 0 del; 0 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/cw.c

8411 Build should warn when linking against libraries outside proto area
10 lines changed: 9 ins; 0 del; 1 mod; 1917 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/make/lib/makestate/Makefile.com

8411 Build should warn when linking against libraries outside proto area
4 lines changed: 4 ins; 0 del; 0 mod; 40 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.