Code Review for illumos-smb31

Prepared by:Alexander Stetsenko on 2020-Apr-15 01:43 +0300 MSK
Workspace:/x2pool/ws/illumos-smb31 (at 221ea9f4d8ce)
Compare against: origin/master (git@github.com:illumos/illumos-gate.git at 63878f749f68)
Summary of changes: 1065 lines changed: 922 ins; 88 del; 55 mod; 17634 unchg
Patch of changes: illumos-smb31.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/smbsrv/smbd/server.xml

12513 SMB 3.1.1 support for server
3 lines changed: 2 ins; 0 del; 1 mod; 284 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libfksmbsrv/Makefile.com

12513 SMB 3.1.1 support for server
4 lines changed: 4 ins; 0 del; 0 mod; 283 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libfksmbsrv/common/fksmb_encrypt_pkcs.c

12513 SMB 3.1.1 support for server
18 lines changed: 16 ins; 0 del; 2 mod; 113 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/smbsrv/libfksmbsrv/common/fksmb_preauth_pkcs.c

12513 SMB 3.1.1 support for server
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmb/common/libsmb.h

12513 SMB 3.1.1 support for server
3 lines changed: 3 ins; 0 del; 0 mod; 1007 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmb/common/smb_cfg.c

12513 SMB 3.1.1 support for server
42 lines changed: 41 ins; 0 del; 1 mod; 1384 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmb/common/smb_info.c

12513 SMB 3.1.1 support for server
2 lines changed: 2 ins; 0 del; 0 mod; 723 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmb/common/smb_kmod.c

12513 SMB 3.1.1 support for server
2 lines changed: 2 ins; 0 del; 0 mod; 482 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man4/smb.4
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

12513 SMB 3.1.1 support for server
35 lines changed: 35 ins; 0 del; 0 mod; 570 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

12513 SMB 3.1.1 support for server
4 lines changed: 3 ins; 0 del; 1 mod; 2269 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb2_dispatch.c

12513 SMB 3.1.1 support for server
13 lines changed: 10 ins; 0 del; 3 mod; 1759 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb2_negotiate.c

12513 SMB 3.1.1 support for server
308 lines changed: 303 ins; 0 del; 5 mod; 527 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb2_session_setup.c

12513 SMB 3.1.1 support for server
8 lines changed: 8 ins; 0 del; 0 mod; 231 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb2_signing.c

12513 SMB 3.1.1 support for server
86 lines changed: 12 ins; 70 del; 4 mod; 418 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/fs/smbsrv/smb31_preauth.c

12513 SMB 3.1.1 support for server
169 lines changed: 169 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb3_encrypt.c

12513 SMB 3.1.1 support for server
82 lines changed: 47 ins; 15 del; 20 mod; 362 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb3_encrypt_kcf.c

12513 SMB 3.1.1 support for server
62 lines changed: 46 ins; 3 del; 13 mod; 219 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/fs/smbsrv/smb3_kdf.c

12513 SMB 3.1.1 support for server
136 lines changed: 136 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_server.c

12513 SMB 3.1.1 support for server
2 lines changed: 2 ins; 0 del; 0 mod; 2537 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_session.c

12513 SMB 3.1.1 support for server
4 lines changed: 4 ins; 0 del; 0 mod; 1499 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb2_kproto.h

12513 SMB 3.1.1 support for server
5 lines changed: 5 ins; 0 del; 0 mod; 160 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_ioctl.h

12513 SMB 3.1.1 support for server
2 lines changed: 2 ins; 0 del; 0 mod; 220 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_kcrypt.h

12513 SMB 3.1.1 support for server
17 lines changed: 12 ins; 0 del; 5 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_ktypes.h

12513 SMB 3.1.1 support for server
9 lines changed: 9 ins; 0 del; 0 mod; 2236 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smbinfo.h

12513 SMB 3.1.1 support for server
9 lines changed: 9 ins; 0 del; 0 mod; 239 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.