Code Review for illumos-gate

Prepared by: (alp) on 2014-Aug-13 19:33 +0400 MSK
Workspace:/export/home/alp/srcs/local/illumos-gate (at c5fdb0aacaa6)
Compare against: openssl-initial-i (at 6720f79b688c)
Summary of changes: 10178 lines changed: 10085 ins; 1 del; 92 mod; 24351 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/include/bn_lcl.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
7 lines changed: 0 ins; 0 del; 7 mod; 508 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/include/cryptlib.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
2 lines changed: 2 ins; 0 del; 0 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/include/des_locl.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 431 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/include/md32_common.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
7 lines changed: 0 ins; 0 del; 7 mod; 408 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/include/modes_lcl.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
6 lines changed: 0 ins; 0 del; 6 mod; 121 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/include/openssl/engine.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 1 ins; 0 del; 0 mod; 842 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/include/openssl/opensslconf.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
172 lines changed: 161 ins; 0 del; 11 mod; 224 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/openssl/include/pkcs11.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
299 lines changed: 299 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/openssl/include/pkcs11f.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
912 lines changed: 912 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/openssl/include/pkcs11t.h

4853 illumos-gate is not lint-clean when built with openssl 1.0
1885 lines changed: 1885 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/bn/bn_const.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 400 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/bn/bn_div.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
4 lines changed: 0 ins; 0 del; 4 mod; 444 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/bn/x86_64-gcc.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
22 lines changed: 0 ins; 0 del; 22 mod; 584 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/camellia/cmll_cfb.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 1 ins; 0 del; 0 mod; 138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/cast/c_enc.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
3 lines changed: 0 ins; 0 del; 3 mod; 205 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/cast/c_skey.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
2 lines changed: 0 ins; 0 del; 2 mod; 170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/cms/cms_asn1.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
2 lines changed: 0 ins; 0 del; 2 mod; 386 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/cms/cms_att.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
2 lines changed: 0 ins; 0 del; 2 mod; 193 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/cms/cms_io.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
2 lines changed: 0 ins; 0 del; 2 mod; 130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/cms/cms_lib.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
2 lines changed: 0 ins; 0 del; 2 mod; 620 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/cryptlib.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
80 lines changed: 79 ins; 0 del; 1 mod; 939 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/des/des_enc.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
2 lines changed: 0 ins; 0 del; 2 mod; 398 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/engine/eng_all.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
3 lines changed: 3 ins; 0 del; 0 mod; 135 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/openssl/libsunw_crypto/engine/hw_pk11.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
3660 lines changed: 3660 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/openssl/libsunw_crypto/engine/hw_pk11_err.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
257 lines changed: 257 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/openssl/libsunw_crypto/engine/hw_pk11_pub.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
2805 lines changed: 2805 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/evp/e_aes_cbc_hmac_sha1.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 580 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/ex_data.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 635 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/mem_dbg.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 873 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/o_str.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/o_time.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 371 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/pl/keysets.pl

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/pl/x86_64-xlate.pl

4853 illumos-gate is not lint-clean when built with openssl 1.0
6 lines changed: 5 ins; 0 del; 1 mod; 1079 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/pl/x86_64cpuid.pl

4853 illumos-gate is not lint-clean when built with openssl 1.0
3 lines changed: 3 ins; 0 del; 0 mod; 284 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/pl/x86asm.pl

4853 illumos-gate is not lint-clean when built with openssl 1.0
3 lines changed: 3 ins; 0 del; 0 mod; 260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/pl/x86cpuid.pl

4853 illumos-gate is not lint-clean when built with openssl 1.0
6 lines changed: 5 ins; 0 del; 1 mod; 357 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/pl/x86gas.pl

4853 illumos-gate is not lint-clean when built with openssl 1.0
3 lines changed: 2 ins; 0 del; 1 mod; 252 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/pqueue/pqueue.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/ts/ts_lib.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 144 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/ts/ts_rsp_print.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 286 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_crypto/x509v3/v3_utl.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 873 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_ssl/bio_ssl.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 1 ins; 0 del; 0 mod; 605 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_ssl/d1_both.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
3 lines changed: 0 ins; 1 del; 2 mod; 1630 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_ssl/d1_srtp.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 493 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_ssl/s3_clnt.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 1 ins; 0 del; 0 mod; 3405 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/openssl/libsunw_ssl/s3_lib.c

4853 illumos-gate is not lint-clean when built with openssl 1.0
1 line changed: 0 ins; 0 del; 1 mod; 4292 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.