Code Review for illumos-gate

Prepared by:Alexander Pyhalov (alp) on 2014-Jun-02 17:29 +0400 MSK
Workspace:/home/alp/srcs/illumos-gate (at 7a85f63a9eb8)
Compare against: master (at adf340778b67)
Summary of changes: 204 lines changed: 106 ins; 87 del; 11 mod; 4735 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
1 line changed: 1 ins; 0 del; 0 mod; 1158 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/Makefile.perl

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
3 lines changed: 2 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/Makefile.targ

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
2 lines changed: 0 ins; 0 del; 2 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/Makefile

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
5 lines changed: 4 ins; 0 del; 1 mod; 718 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.mf

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
5 lines changed: 4 ins; 0 del; 1 mod; 1898 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-appcert.mf

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-object-file.mf

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
1 line changed: 0 ins; 0 del; 1 mod; 162 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-opensolaris-osnet.mf

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
2 lines changed: 0 ins; 1 del; 1 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/print-lp-print-client-commands.mf

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
1 line changed: 0 ins; 0 del; 1 mod; 83 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/pkg/manifests/runtime-perl-510-module-sun-solaris.mf (deleted)

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
86 lines changed: 0 ins; 86 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/runtime-perl-module-sun-solaris.mf

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-network-smtp-sendmail.mf

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
1 line changed: 0 ins; 0 del; 1 mod; 234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-extended-system-utilities.mf

4863 illumos-gate can't be built with fresh perl versions
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
1 line changed: 0 ins; 0 del; 1 mod; 280 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.